Skip to content

Typescript/keyboard #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Aug 18, 2021
Merged

Typescript/keyboard #1449

merged 46 commits into from
Aug 18, 2021

Conversation

mendyEdri
Copy link
Contributor

@mendyEdri mendyEdri commented Aug 5, 2021 •
edited
Loading

Description

Sorry for the large PR.
Migrate native component library to typescript (the JS parts obviously 🌎)
This PR still needs to compile run typescript to create new declaration files but I'll do it in a separate PR.

Changelog

Part 1 of migrating Keyboard, WheelPicker (native), SafeArea and HighlighterOverlayView to typescript.

Depends on

TBD

mendyEdri added 30 commits August 2, 2021 16:13
@mendyEdri
Keyboard index.js -> index.ts
d9bd00e
@mendyEdri
KeyboardAwareInsetsView.js -> KeyboardAwareInsetsView.tsx
574b94b
@mendyEdri
KeyboardTrackingView.android.js -> KeyboardTrackingView.android.tsx
645f89e
@mendyEdri
KeyboardTrackingView.js -> KeyboardTrackingView.tsx
8d030b3
@mendyEdri
KeyboardTrackingView to work with ios and android
50d62d6
@mendyEdri
lib/components index.js -> index.ts
86a13db
@mendyEdri
index.js -> index.ts
e940d64
@mendyEdri
HighlighterOverlayView.js -> HighlighterOverlayView.tsx
035c485
@mendyEdri
HighlighterOverlayView.js -> HighlighterOverlayView.tsx
3c60dee
@mendyEdri
moved into own folder
9fcd125
@mendyEdri
CustomKeyboardView.android.js to CustomKeyboardView.android.tsx
b5a2d8d
@mendyEdri
CustomKeyboardView.ios.js -> CustomKeyboardView.ios.tsx
be0fce0
@mendyEdri
TextInputKeyboardManager in it's own folder
c21e54a
@mendyEdri
TextInputKeyboardManager.ios.js -> TextInputKeyboardManager.ios.tsx
1832c9a
@mendyEdri
TextInputKeyboardManager.android.js -> TextInputKeyboardManager.andro…
1fd9344 
…id.tsx
@mendyEdri
TextInputKeyboardManager should be ts not tsx, fixed it
bb39962
@mendyEdri
create index file for KeyboardInputKeyboardManager to work with diffe…
99e6e73 
…rent files for iOS and Android
@mendyEdri
CustomKeyboardViewBase to tsx
fff2c72
@mendyEdri
KeyboardAccessoryView to tsx
356a512
@mendyEdri
files to typescript
2c834c6
@mendyEdri
SafeAreaSpacer to typescript
80e4bed
@mendyEdri
WheelPicker to tsx
0c5568b
@mendyEdri
lib index fix ts error
a6f78f1
@mendyEdri
CustomKeyboardViewBase to ts compatible
07bef5a
@mendyEdri
CustomKeyboardView to ts compatible
dce7d2e
@mendyEdri
ts fix
e5dd04c
@mendyEdri
SafeAreaSpacerView ts fix
3f64441
@mendyEdri
WheelPicker index to ts
98c6ab9
@mendyEdri
CustomKeyboardView to ts
e03b507
@mendyEdri
SafeAreaInsetsManager ts compatible
85f8982
@mendyEdri mendyEdri requested a review from ethanshar August 5, 2021 13:50
ethanshar
ethanshar reviewed Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mendyEdri
I noticed some components don't work in this PR
The old WheelPicker and SafeArea spaces example screens throw an exception
Can you please take a look before I continue reviewing

@mendyEdri
Copy link
Contributor Author

@mendyEdri
I noticed some components don't work in this PR
The old WheelPicker and SafeArea spaces example screens throw an exception
Can you please take a look before I continue reviewing

Oh ok I'll take a look

@mendyEdri mendyEdri requested a review from ethanshar August 15, 2021 08:43
@ethanshar ethanshar merged commit 8a36fa7 into master Aug 18, 2021
ethanshar added a commit that referenced this pull request Aug 18, 2021
@ethanshar
Revert "Typescript/keyboard (#1449)"
5feda01 
This reverts commit 8a36fa7.
@ethanshar ethanshar mentioned this pull request Aug 18, 2021
Merged
ethanshar added a commit that referenced this pull request Aug 18, 2021
@ethanshar
Revert "Typescript/keyboard (#1449)" (#1476)
2e59194 
This reverts commit 8a36fa7.
M-i-k-e-l added a commit that referenced this pull request Aug 18, 2021
@M-i-k-e-l
Merge branch 'master' into feat/add-statics-to-forward-ref
8586e3f 
* master:
  Revert "Typescript/keyboard (#1449)" (#1476)
  Typescript/keyboard (#1449)
  Update generated types
  Improve GridView screen and add containerProps prop to GridListItem
ethanshar added a commit that referenced this pull request Aug 23, 2021
@ethanshar
Revert "Revert "Typescript/keyboard (#1449)" (#1476)"
ae528a3 
This reverts commit 2e59194.
ethanshar added a commit that referenced this pull request Aug 23, 2021
@ethanshar
Typescript/keyboard (#1488)
8e5a3fb 
* Revert "Revert "Typescript/keyboard (#1449)" (#1476)"

This reverts commit 2e59194.

* Fix TS issues leftover in Keyboard components

* Rearrange generated types
@mendyEdri mendyEdri deleted the typescript/keyboard branch December 27, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendyEdri @ethanshar