Skip to content

Typescript/state screen #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 9, 2021
Merged

Typescript/state screen #1455

merged 15 commits into from
Aug 9, 2021

Conversation

mendyEdri
Copy link
Contributor

Description

Migrate StateScreen component to typescript

Changelog

StateScreen component migrated to typescript.

@mendyEdri mendyEdri requested a review from M-i-k-e-l August 8, 2021 08:48
M-i-k-e-l
M-i-k-e-l reviewed Aug 8, 2021
View reviewed changes
src/components/stateScreen/index.tsx
@@ -88,7 +59,10 @@ export default class StateScreen extends BaseComponent {
}
}

function createStyles(isRemoteImage) {
export {StateScreenProps};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's the props 🤦‍♂️

@mendyEdri mendyEdri requested a review from M-i-k-e-l August 8, 2021 13:03
M-i-k-e-l
M-i-k-e-l approved these changes Aug 8, 2021
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, there's a conflict

src/components/stateScreen/index.tsx
@@ -88,7 +59,10 @@ export default class StateScreen extends BaseComponent {
}
}

function createStyles(isRemoteImage) {
export {StateScreenProps};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's the props 🤦‍♂️

@M-i-k-e-l M-i-k-e-l merged commit 5525aa3 into master Aug 9, 2021
@mendyEdri mendyEdri deleted the typescript/state-screen branch December 27, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendyEdri @M-i-k-e-l