Skip to content

expose an imperative validate method on Incubator.TextField component #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

Expose an imperative validate method on Incubator.TextField

feature request #1418

Changelog

Expose an imperative validate method on Incubator.TextField

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool feature!
I left one comment about making the example more clear :)

@@ -136,6 +147,7 @@ export default class TextFieldScreen extends Component {
</View>

<TextField
ref={this.inputWithValidation}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is not clear enough IMO,
Worth adding a new textField without validateOnChange prop, and put the validate button next to it :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ethanshar ethanshar requested a review from lidord-wix August 8, 2021 13:48
@lidord-wix lidord-wix merged commit caabd21 into master Aug 8, 2021
@ethanshar ethanshar deleted the feat/TextField_validateMethod branch November 30, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants