Allow setting windowSoftInputMode #1462
Conversation
| if (mIsShown) { | ||
| Window window = getWindow(); | ||
| if (window != null) { | ||
| window.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_PAN); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe extract this functionality to a separate method since it pretty much returns itself
There was a problem hiding this comment.
Do you mean the setKeyboardOverlayMode and the clearKeyboardOverlayMode?
There was a problem hiding this comment.
Yes, they are very similar, don't you think?
There was a problem hiding this comment.
I do think so, I usually try to minimize changes in these files; done.
Just to be sure it's not missed, there is a small risk in this PR.
There was a problem hiding this comment.
We have a few Activities that have a different windowSoftInputMode than adjustResize they might look different if this bug has indeed overridden their selection.
I can send you the details in DM.
There was a problem hiding this comment.
@ethanshar, do we want to talk about this?
There was a problem hiding this comment.
We should (:
Can you write this down and raise it in the next sprint meeting
Description
Currently our
CustomKeyboardLayoutis forcing the app to havewindowSoftInputMode=SOFT_INPUT_ADJUST_RESIZEeven if you did not use aKeyboardAccessoryViewin your app.This fix changes this behaviour to only occur if a
KeyboardAccessoryViewis loaded (even in a different tab etc).@ethanshar, I've tested on both public and private demo apps, but I think it isn't without risk, what's your opinion?
Changelog
Do not force SOFT_INPUT_ADJUST_RESIZE on Android apps.
Fixes #1360