Fix/ WheelPicker alignment and touch area #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
the
Important for Next Release
ethanshar
reviewed
Aug 11, 2021
src/incubator/WheelPicker/index.tsx
Outdated
| <View centerV> | ||
| <Text marginL-s2 text80M {...labelProps} color={activeTextColor} style={labelStyle}> | ||
| <View style={{position: 'absolute', right: 0, top: 0, bottom: 0}} centerV pointerEvents="none"> | ||
| <Text marginL-s2 marginR-s5 text80M {...labelProps} color={activeTextColor} style={labelStyle}> |
There was a problem hiding this comment.
Why do we need to have marginR-s5 here?
There was a problem hiding this comment.
The separators should be wider than the text in s5 from each side, the fake label takes this margin so the real label should do so too
ethanshar
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix WheelPicker alignment and touch area
WOAUILIB-1920
Changelog
Fix WheelPicker alignment and touch area