Skip to content

Update Button disabled color to grey50 according to guidelines #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Update Button disabled color to grey50 according to guidelines #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/button/ButtonConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ export const MIN_WIDTH = {
};

export const DEFAULT_SIZE = ButtonSize.large;
export const DISABLED_COLOR = Colors.dark60;
export const DISABLED_COLOR = Colors.grey50;
8 changes: 4 additions & 4 deletions src/components/button/__tests__/__snapshots__/index.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ exports[`Button backgroundColor should return theme disabled color if button is
style={
Object {
"alignItems": "center",
"backgroundColor": "#C2C7CB",
"backgroundColor": "#D2D6D8",
"borderRadius": 999,
"flexDirection": "row",
"justifyContent": "center",
Expand Down Expand Up @@ -1913,7 +1913,7 @@ exports[`Button icon should return icon style according to different variations
style={
Object {
"alignItems": "center",
"backgroundColor": "#C2C7CB",
"backgroundColor": "#D2D6D8",
"borderRadius": 999,
"flexDirection": "row",
"justifyContent": "center",
Expand Down Expand Up @@ -2770,7 +2770,7 @@ exports[`Button labelColor should return disabled text color according to theme
"lineHeight": 24,
},
Object {
"color": "#C2C7CB",
"color": "#D2D6D8",
},
Object {},
Object {},
Expand Down Expand Up @@ -3302,7 +3302,7 @@ exports[`Button outline should return disabled color for outline if button is di
"lineHeight": 24,
},
Object {
"color": "#C2C7CB",
"color": "#D2D6D8",
},
Object {},
Object {},
Expand Down