[Inspiration screens]: Product Page & Twitter screens #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Aug 12, 2021
Comment on lines
77
to
96
| <View marginV-s2 paddingV-s2 style={{borderColor: Colors.dark70, borderBottomWidth: 1}}> | ||
| <Text dark30>Color</Text> | ||
| <TouchableOpacity row centerV spread onPress={()=> this.setState({isColor: true})}> | ||
| <View row centerV> | ||
| <View style={{width: 14, height: 14, borderRadius: 12, marginRight: 6}} backgroundColor={colorOption.color}/> | ||
| <Text dark10 text70>{colorOption.name}</Text> | ||
| </View> | ||
| <Image source={require('../../../assets/icons/chevronDown.png')}/> | ||
| </TouchableOpacity> | ||
| </View> | ||
| <ActionSheet | ||
| title={'Select a Color'} | ||
| options={[ | ||
| {label: colorOptions.red.name, onPress: () => this.pickOption(colorOptions.red)}, | ||
| {label: colorOptions.green.name, onPress: () => this.pickOption(colorOptions.green)}, | ||
| {label: colorOptions.blue.name, onPress: () => this.pickOption(colorOptions.blue)}, | ||
| ]} | ||
| visible={isColor} | ||
| onDismiss={()=> this.setState({isColor: false})} | ||
| /> |
There was a problem hiding this comment.
Why not use the Picker component?
There was a problem hiding this comment.
I thought that Picker doesn't have ActionSheet, but seems like it has in custom options
There was a problem hiding this comment.
Yes, technically you achieve the same behavior with custom item render.
Comment on lines
98
to
116
| <View marginV-s2 paddingV-s2 style={{borderColor: Colors.dark70, borderBottomWidth: 1}}> | ||
| <Text dark30>Size</Text> | ||
| <TouchableOpacity row centerV spread onPress={()=> this.setState({isSize: true})}> | ||
| <View row centerV> | ||
| <Text dark10 text70>{sizeOption.name}</Text> | ||
| </View> | ||
| <Image source={require('../../../assets/icons/chevronDown.png')}/> | ||
| </TouchableOpacity> | ||
| </View> | ||
| <ActionSheet | ||
| title={'Select a Size'} | ||
| options={[ | ||
| {label: sizeOptions.s.name, onPress: () => this.pickOption(sizeOptions.s)}, | ||
| {label: sizeOptions.m.name, onPress: () => this.pickOption(sizeOptions.m)}, | ||
| {label: sizeOptions.l.name, onPress: () => this.pickOption(sizeOptions.l)}, | ||
| ]} | ||
| visible={isSize} | ||
| onDismiss={()=> this.setState({isSize: false})} | ||
| /> |
There was a problem hiding this comment.
Same here, consider using the Picker component
|
@maeschli Let me know if you still have time to fix my comments. |
mariaborovyk
changed the title
ethanshar
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created Demo Screens in Inspiration Screens section
Changelog