Infra/test renderer #1470
Merged
Infra/test renderer #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Aug 16, 2021
There was a problem hiding this comment.
Looks great!
Very intuitive and clear... I wrote few small comments.
Anyway, I'd love to see it working on other components.
We can think later on which other components or scenarios..
For instance, we had several RTL regression issues recently, I wonder if this is something we test easily with test-renderer. WDYT?
ethanshar
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A POC for component tests inside uilib. added a few tests to
Hintcomponent that validates a recent bugs we had will be covered with tests.We are using now
@testing-library/react-nativefor this component testing.Changelog
Infra, added first component-tests to
Hintcomponent.