dean-added-auto-scroll-classifier #1474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Aug 24, 2021
src/components/carousel/types.tsx
Outdated
| @@ -105,6 +106,7 @@ export interface CarouselState { | |||
| pageHeight: number; | |||
| initialOffset: PointPropType; | |||
| prevProps: CarouselProps; | |||
| // isAutoScrolled:boolean //dean | |||
There was a problem hiding this comment.
Is that needed?
Suggested change
| // isAutoScrolled:boolean //dean |
src/components/carousel/index.tsx
Outdated
Comment on lines
279
to
283
|
|
||
There was a problem hiding this comment.
I suggest to run document formatting to remove all redundant spaces that were added
If you use VSCode you can run the Format Document on the file
src/components/carousel/types.tsx
Outdated
| @@ -40,7 +40,7 @@ export interface CarouselProps extends ScrollViewProps { | |||
| /** | |||
| * callback for when page has changed | |||
| */ | |||
| onChangePage?: (newPageIndex: number, oldPageIndex: number) => void; | |||
| onChangePage?: (newPageIndex: number, oldPageIndex: number, isAutoScrolled: boolean) => void; | |||
There was a problem hiding this comment.
Consider passing the new (last) argument as an object of "info"
If in the future we'll have to pass more info props then instead of adding more arguments, we'll just add to this info object you created.
deanblinder
force-pushed
the
dean/add-option-to-chack-if-image-scrolled-auto-or-manually
branch
from
0755ac4 to
372d2ac
Compare
ethanshar
approved these changes
Sep 9, 2021
…-auto-or-manually
ethanshar
approved these changes
Sep 9, 2021
ethanshar
deleted the
dean/add-option-to-chack-if-image-scrolled-auto-or-manually
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i added a parameter "isAutoScrolled" on the "onChangePage" method to classify if the image was auto or manually scrolled.
Changelog
the change was in this file "src/components/carousel/index.tsx" lines 40,47,171,264