Feat/chips input v2 #1490
Merged
Feat/chips input v2 #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Oct 20, 2021
Inbal-Tish
reviewed
Oct 20, 2021
Inbal-Tish
reviewed
Oct 20, 2021
Inbal-Tish
reviewed
Oct 20, 2021
Inbal-Tish
reviewed
Oct 20, 2021
Inbal-Tish
reviewed
Oct 21, 2021
Inbal-Tish
reviewed
Oct 21, 2021
Inbal-Tish
reviewed
Oct 25, 2021
Inbal-Tish
reviewed
Oct 25, 2021
|
@mendyEdri What's the status on this one? Did you finish with my comments? |
@Inbal-Tish Yes, if it passed don't merge it just yet, I want to test it in Spaces first. Thank you! |
|
@mendyEdri Hi. I don't see the last changes. Did you push? |
Right, pushed |
Inbal-Tish
reviewed
Nov 2, 2021
src/components/chipsInput/index.tsx
Outdated
| this.removeMarkedTag(); | ||
| } | ||
| } | ||
|
|
||
| onKeyPress = (event: NativeSyntheticEvent<TextInputKeyPressEventData>) => { | ||
| _.invoke(this.props, 'onKeyPress', event); | ||
|
|
||
| const {disableTagRemoval} = this.props; | ||
| if (disableTagRemoval) { |
There was a problem hiding this comment.
this logic should move to removeTag method
There was a problem hiding this comment.
I don't see any changes here...
Inbal-Tish
approved these changes
Nov 3, 2021
Inbal-Tish
reviewed
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a few features to ChipsInput:
maxHeightfor scrolling optionleftElementfor ui like search icon etc'Chipcomponent internally for a better ui and more convenient apititlethat floating above the chipsChangelog
ChipsInput'stagswill be deprecated, please usechipsPropsinstead.Tasks