[Lint] Fix findValueNodeOfIdentifier - take into account valueNode can be false #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial value is false (related to isRequired)
Inbal-Tish
reviewed
Aug 24, 2021
| { | ||
| options: ruleOptions, | ||
| code: 'import {Picker} from \'module-with-deprecations\'; <Picker t="title" s="subtitle" migrate/>', | ||
| errors: [ |
There was a problem hiding this comment.
If that's a valid example why the error? (Same for the next entry)
There was a problem hiding this comment.
10x, copy paste mistake, wonder why it's not failing the tests; removed.
There was a problem hiding this comment.
It's not failing the tests because these are valid scenarios and the tests don't need this key...
Inbal-Tish
approved these changes
Aug 26, 2021
M-i-k-e-l
deleted the
lint/fix-find-value-node-related-to-required-prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Lint] Fix findValueNodeOfIdentifier - take into account that valueNode initial value is false (related to isRequired)
Changelog
[Lint] Fix findValueNodeOfIdentifier - take into account that valueNode initial value is false (related to isRequired)