Feat/tab controller 2 orientation try 3 #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the useEffect that resets the data in useScrollToItem is called after the useEffect that triggers the onLayout from fixed width items (and data is lost).
ethanshar
reviewed
Sep 9, 2021
ethanshar
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabController2 - add support for orientation change.
Changed the key in
TabBarlike we've discussed, unfortunately this change still required many changes because the key is changed insideTabBarand not onTabBar(not by the user), and so the hooks are not recreated.Following each commit will make it easier.
Testing with both scrollable (i.e. phone) and non scrollable (i.e. high resolution tablet) will allow you to see the bugs fixed in the commits.
Changelog
TabController2 - add support for orientation change.