Skip to content

Feat/ TextField initial width #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Feat/ TextField initial width #1523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/incubator/TextField/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ const TextField = (props: InternalTextFieldProps) => {
<View style={[paddings, fieldStyle]}>
<View row centerV>
{leadingAccessory}
<View flex>
<View flexG>
{floatingPlaceholder && (
<FloatingPlaceholder
placeholder={placeholder}
Expand All @@ -187,12 +187,13 @@ const TextField = (props: InternalTextFieldProps) => {
/>
)}
<Input
placeholderTextColor={floatingPlaceholder ? 'transparent' : undefined}
{...others}
style={[typographyStyle, colorStyle, others.style]}
onFocus={onFocus}
onBlur={onBlur}
onChangeText={onChangeText}
placeholder={floatingPlaceholder ? undefined : placeholder}
placeholder={placeholder}
Comment on lines -195 to +196
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was that required eventually?
I see the flexG enough fix the issue..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't fix it.. we have to pass the placeholder to set the actual width

hint={hint}
/>
</View>
Expand Down