Support passing a custom formatter to TextField #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support passing a static validation message regardless to the validate prop * Fix typing * Fix validate typing
ethanshar
added
the
Important for Next Release
mendyEdri
reviewed
Oct 4, 2021
src/incubator/TextField/Input.tsx
Outdated
| /** | ||
| * Custom formatter for the input value (used only when input if not focused) | ||
| */ | ||
| formatter?: (value?: string) => string; |
There was a problem hiding this comment.
Is it possible for the formatter to return undefined?
There was a problem hiding this comment.
Do you mean whether we should have the following signature?
(value?: string) => string | undefined;?
There was a problem hiding this comment.
Yes, in second thought, when you format something and it's not correct, you return the same value + an error, right?
There was a problem hiding this comment.
Well it's really up to the user implementation.. they can do whatever..
Technically, we can support returning undefined since it's a valid value for TextField.
I'll change it
mendyEdri
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support passing a custom formatter to TextField
Changelog
Support passing a custom formatter to TextField