Skip to content

ThemeManager - removing 'setTheme' #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2021
Merged

ThemeManager - removing 'setTheme' #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion generatedTypes/src/style/themeManager.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export declare class ThemeManager {
forcedTheme: {
components: Extendable;
};
setTheme(overrides: Dictionary<string>): void;
getTheme(): {
primaryColor: string;
CTA: {
Expand Down
6 changes: 0 additions & 6 deletions src/style/themeManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ export class ThemeManager {
components: {} as Extendable
}

//TODO: deprecate on V6
setTheme(overrides: Dictionary<string>) {
console.warn('ThemeManager.setTheme() is deprecated. Please remove usage before next uilib major version update. Consider using ThemeManager.setComponentTheme instead');
this.theme = _.merge(this.theme, overrides);
}

getTheme() {
return this.theme;
}
Expand Down