Skip to content

Fix support for setting color scheme manually #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 29, 2021
Merged

Fix support for setting color scheme manually #1561

merged 6 commits into from
Sep 29, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

Fix support for setting color scheme manually (Fix #1548)

  • Created Scheme class to handle all schemes logic
  • Move relevant logic from Colors class to Scheme class
  • Change appearance change registration in asBaseComponent with scheme change registration
  • Update DarkModeScreen example to showcase a scenario of manual scheme change

Changelog

Fix support for setting color scheme manually

lidord-wix
lidord-wix reviewed Sep 19, 2021
View reviewed changes
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Cool!
I left few small comments :)

@lidord-wix lidord-wix merged commit 5365f22 into master Sep 29, 2021
@ethanshar ethanshar deleted the infra/schemeClass branch November 30, 2021 08:14
@poolieweb poolieweb mentioned this pull request May 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colors.setScheme works fine for Views but not for Text
2 participants
@ethanshar @lidord-wix