New Dialog using the new Pan and Transition Views

[M-i-k-e-l]

Description

New Dialog using the new Pan and Transition Views
This will have conflicts with #1574
This is not feature complete, but not bad.
Missing features (or things I did not test yet): alignments, fix Android measureInWindow bug, header (do we need it? probably not), default style(?), onOrientationChange, useSafeArea.

Changelog

New Dialog using the new Pan and Transition Views

[ethanshar]

I think we talked about it already..
It'll be great if we can refactor the existing Dialog component and use the new infra without having a new component or any migration

[M-i-k-e-l]

I think we talked about it already.. It'll be great if we can refactor the existing Dialog component and use the new infra without having a new component or any migration

We did talk about it; I did say that it might not be possible if we want to remove the older pan views (but this can be done in v7).
However I do think refactoring is not the best course of action since we have a lot of logic that we may not need and if we want cleaner code I think this is a better way: small PRs that will get us to the same APIs, and then switch the implementation.
WDYT?

[ethanshar]

We did talk about it; I did say that it might not be possible if we want to remove the older pan views (but this can be done in v7). However I do think refactoring is not the best course of action since we have a lot of logic that we may not need and if we want cleaner code I think this is a better way: small PRs that will get us to the same APIs, and then switch the implementation. WDYT?

So yes, let's go with small PRs
And.. as discussed let's try to replace enums with string values (eg `'up' | 'down' | 'left'....)

[ethanshar]

Why did u change to up/down?

[M-i-k-e-l]

So it will be backwards compatible with the old enum and remove some awkward "translations" between the two enums.

[ethanshar]

I see.. bummer I prefer top/bottom on up/down
If the relevant components are in Incubator I don't mind changing it to top/bottom everywhere, I don't consider it a breaking change

[M-i-k-e-l]

It'll require a migration (public, private, apps...) because we're using up\down here.
Or some code I removed to translate it (and you did not like, if I recall correctly).
I figured we can use the old convention, at least for now, and a migration can be done in any time.

[ethanshar]

ok 👍

[ethanshar]

Approved, build is still running you can merge once it's done