Skip to content

Image - add OverlayIntensity #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2021
Merged

Image - add OverlayIntensity #1584

merged 4 commits into from
Oct 5, 2021

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

Image - add OverlayIntensity

Changelog

Image - add OverlayIntensity

@M-i-k-e-l M-i-k-e-l added the Important for Next Release PR that must be included in the release version label Oct 4, 2021
@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix October 4, 2021 10:38
@lidord-wix
Copy link
Contributor

There's a weird behavior when moving between types, to reproduce:

  1. set intensity to HIGH
  2. set type to BOTTOM
  3. set type to SOLID

@M-i-k-e-l
Copy link
Collaborator Author

There's a weird behavior when moving between types, to reproduce:

  1. set intensity to HIGH
  2. set type to BOTTOM
  3. set type to SOLID

As we've discussed, this is not a regression and will be handled in the screen with a change of key (since no-one has complained so far and I assume changing the overlay is not common).

@lidord-wix lidord-wix merged commit 41c00e6 into master Oct 5, 2021
@M-i-k-e-l M-i-k-e-l deleted the feat/image-overlay-intensity branch October 5, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @lidord-wix