Update Constants.ts #1585
Merged
Update Constants.ts #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
requested changes
Oct 4, 2021
Update RN version.
ethanshar
requested changes
Oct 5, 2021
package.json
Outdated
| "react-native": "0.64.1", | ||
| "react-native": ">=0.65.0", |
There was a problem hiding this comment.
This should be reverted, migrating to higher version of RN requires more than just changing the version in package.json
There was a problem hiding this comment.
Didn’t know that, sorry about that.
I’ll fix.
Co-authored-by: Ethan Sharabi <[email protected]>
ethanshar
requested changes
Oct 5, 2021
package.json
Outdated
| @@ -99,7 +99,7 @@ | |||
| "react": "17.0.1", | |||
| "react-autobind": "^1.0.6", | |||
| "react-dom": "^15.4.2", | |||
| "react-native": "0.64.1", | |||
| "react-native:"0.64.1", | |||
There was a problem hiding this comment.
You missed a "
Suggested change
| "react-native:"0.64.1", | |
| "react-native": "0.64.1", |
ethanshar
approved these changes
Oct 5, 2021
ethanshar
requested changes
Oct 5, 2021
Comment on lines
+134
to
+138
| if (Dimensions.remove) { | ||
| Dimensions.remove('change', callback); | ||
| } else { | ||
| Dimensions.removeEventListener('change', callback); | ||
| } |
There was a problem hiding this comment.
@tacoelho I approved, but then noticed the build fails.
It's probably because of TS.
The best way to see the errors is to run npm run prepush
Anyway, you can use @ts-expect-error for now
Suggested change
| if (Dimensions.remove) { | |
| Dimensions.remove('change', callback); | |
| } else { | |
| Dimensions.removeEventListener('change', callback); | |
| } | |
| // @ts-expect-error | |
| if (Dimensions.remove) { | |
| // @ts-expect-error | |
| Dimensions.remove('change', callback); | |
| } else { | |
| Dimensions.removeEventListener('change', callback); | |
| } |
ethanshar
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1582
Description
Listener removal to fix bug.
Changelog
Add remove() instead of removeListener to fix the error message