Carousel - fix counter flickering between numbers #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Oct 11, 2021
| @@ -56,7 +56,7 @@ class Carousel extends Component<CarouselProps, CarouselState> { | |||
| containerWidth: undefined, | |||
| // @ts-ignore (defaultProps) | |||
| currentPage: this.shouldUsePageWidth() ? this.getCalcIndex(props.initialPage) : props.initialPage, | |||
| currentStandingPage: props.initialPage, | |||
| currentStandingPage: props.initialPage || 0, | |||
There was a problem hiding this comment.
'initialPage' prop's default value is already 0
Inbal-Tish
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Carousel - fix counter flickering between numbers.
Use
currentStandingPageinstead ofcurrentPage+ a little typescript adjustment.Please note that this will cause the counter to change on actual page change, and not mid change (approved for testing by UX).
Changelog
Carousel - fix counter flickering between numbers.