Skip to content

Fix Expo demo app #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Fix Expo demo app #1594

merged 1 commit into from
Oct 13, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

There's not much to review here, I basically recreated the expo app from scratch using expo latest version and copied over the MainScreen file

Changelog

Fix our Expo demo app

@ethanshar ethanshar requested a review from M-i-k-e-l October 9, 2021 06:23
@ethanshar ethanshar changed the title Recreate expo app Fix Expo demo app Oct 9, 2021
@M-i-k-e-l
Copy link
Collaborator

How do we want to handle unsupported screens (for example IncubatorTextFieldScreen which does not work on iOS and crashes the app on Android)?

@ethanshar
Copy link
Collaborator Author

How do we want to handle unsupported screens (for example IncubatorTextFieldScreen which does not work on iOS and crashes the app on Android)?

TBH, I mostly focused on making the expo demo app work and not show errors.
Im well aware there are still issues there.. hopefully we'll try to fix each separately.

It's a little complicated with Expo cause it doesn't support our native components (like Keyboard)

@M-i-k-e-l
Copy link
Collaborator

How do we want to handle unsupported screens (for example IncubatorTextFieldScreen which does not work on iOS and crashes the app on Android)?

TBH, I mostly focused on making the expo demo app work and not show errors. Im well aware there are still issues there.. hopefully we'll try to fix each separately.

It's a little complicated with Expo cause it doesn't support our native components (like Keyboard)

But for me it crashed on Android, do you want me to look in to this?

@ethanshar
Copy link
Collaborator Author

Yes you can take a look.
It's very strange, I see it throws and error on importing the IncubatorTextField screen but it's there..
Anyway, this PR fixes at least iOS.
We can merge it and work on Android separately. WDYT?

@M-i-k-e-l
Copy link
Collaborator

Created a ticket for Android

@M-i-k-e-l M-i-k-e-l merged commit 1fc4fbb into master Oct 13, 2021
@ethanshar ethanshar deleted the infra/fixExpoApp branch November 30, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants