-
Notifications
You must be signed in to change notification settings - Fork 734
Upgrade to rn65 #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to rn65 #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
When I use the upgrade-helper I see they also renamed the _editorconfig
file to .editorconfig
, but I'm not sure if it's mandatory..
@@ -52,7 +49,6 @@ deprecated-type=warn | |||
unsafe-getters-setters=warn | |||
unnecessary-invariant=warn | |||
signature-verification-failure=warn | |||
deprecated-utility=error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentionally removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just override the whole new file of .flowconfig.
TBH, it's irrelevant because we don't use flow in our project anyway.. it doesn't really matter
@@ -26,6 +25,7 @@ buildscript { | |||
|
|||
allprojects { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can remove the jcenter()
from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed and brought it back, cause without this one there's an issue during Android build
It's a known issue with react-native-blur dependency
Yes, it's not really relevant to us. |
Description
Upgrade demo app to react-native 0.65
Changelog
Upgrade demo app to react-native 0.65