Skip to content

Upgrade to rn65 #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 17, 2021
Merged

Upgrade to rn65 #1604

merged 7 commits into from
Oct 17, 2021

Conversation

ethanshar
Copy link
Collaborator

@ethanshar ethanshar commented Oct 16, 2021

Description

Upgrade demo app to react-native 0.65

Changelog

Upgrade demo app to react-native 0.65

Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
When I use the upgrade-helper I see they also renamed the _editorconfig file to .editorconfig, but I'm not sure if it's mandatory..

@@ -52,7 +49,6 @@ deprecated-type=warn
unsafe-getters-setters=warn
unnecessary-invariant=warn
signature-verification-failure=warn
deprecated-utility=error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentionally removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just override the whole new file of .flowconfig.
TBH, it's irrelevant because we don't use flow in our project anyway.. it doesn't really matter

@@ -26,6 +25,7 @@ buildscript {

allprojects {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove the jcenter() from here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed and brought it back, cause without this one there's an issue during Android build
It's a known issue with react-native-blur dependency

@ethanshar
Copy link
Collaborator Author

Looks good overall.
When I use the upgrade-helper I see they also renamed the _editorconfig file to .editorconfig, but I'm not sure if it's mandatory..

Yes, it's not really relevant to us.
Some files are just project files, .flowconfig is also not that relevant to us

@ethanshar ethanshar requested a review from lidord-wix October 17, 2021 12:51
@lidord-wix lidord-wix merged commit 951d694 into master Oct 17, 2021
@ethanshar ethanshar deleted the infra/rn65 branch April 18, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants