Skip to content

Fix/ TextField (incubator) validation message on start #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix/ TextField (incubator) validation message on start #1613

merged 2 commits into from
Oct 20, 2021

Conversation

lidord-wix
Copy link
Contributor

Description

Fix validation message on start in TextField (incubator)
WOAUILIB-2162

Changelog

Fix validation message on start in TextField (incubator)

@lidord-wix lidord-wix requested a review from ethanshar October 19, 2021 10:27
@ethanshar
Copy link
Collaborator

@lidord-wix
If I understand correctly the issue..
They want to pass a validationMessage (without validate prop) but still have the validation lifecycle controlled by us, meaning the validation message will be shown based on validateOnChange/validateOnStart/validateOnBlur ?

I think it's a problem, if we want validationMessage to be fully controlled when validate wasn't passed then I don't think we should control when it's being displayed.
They should have full control

@ethanshar ethanshar merged commit 897689a into master Oct 20, 2021
@lidord-wix lidord-wix deleted the fix/textField_validateOnStart branch November 1, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidord-wix @ethanshar