Infra/incubator to2 #1616
Merged
Infra/incubator to2 #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendyEdri
reviewed
Oct 24, 2021
|
|
||
| const onPress = useCallback(() => { | ||
| props.onPress?.(props); | ||
| }, [props.onPress, props.customValue]); |
There was a problem hiding this comment.
Since we use props as an argument, could be that we need to specify it in the dependency array as well?
There was a problem hiding this comment.
I made the assumption that the only prop that user is actually expecting is the customValue
|
|
||
| const onLongPress = useCallback(() => { | ||
| props.onLongPress?.(props); | ||
| }, [props.onLongPress, props.customValue]); |
There was a problem hiding this comment.
Also here, props warning
mendyEdri
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace implementation of Incubator.TouchableOpacity with the new one (Incubator.TouchableOpacity2)
Changelog
Update Incubator.TouchableOpacity implementation to use Reanimated v2