-
Notifications
You must be signed in to change notification settings - Fork 734
Feat/hint pressable target #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Few issues before reviewing the code -
|
Technically there's no point to use onBackgroundPress with the new one. |
As discussed, the new behaviour doesn't work with the onBackgroundPress prop |
@lidord-wix I'll change the PR description and changelog you can see details there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now :)
Just need to clean two leftovers of the targetRef
from the screen.
I'm approving so you can remove it and merge
} | ||
|
||
export default class HintsScreen extends Component<HintScreenProps> { | ||
targetRef = React.createRef(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need it anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
style={{alignSelf: targetPosition}} | ||
testID={'Hint.button'} | ||
ref={this.targetRef} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. thanks
Description
backdropColor
to allow users to color the background which gives more emphasis on the hinted targetWOAUILIB-2177
Changelog
backdropColor
prop to color overlay background