Skip to content

TextField - Support passing custom preset and use it in fieldStyle callback #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

  • Support passing custom preset to TextField
  • Pass on preset to fieldStyle callback so users can react to different presets

Changelog

TextField - Support custom preset and pass it on to fieldStyle callback for custom preset styles

@ethanshar ethanshar requested a review from lidord-wix November 1, 2021 08:50
@ethanshar ethanshar changed the title Support passing custom preset and use it in fieldStyle callback TextField - Support passing custom preset and use it in fieldStyle callback Nov 1, 2021
Copy link
Contributor

@lidord-wix lidord-wix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we pass the preset to the user? we're getting it from the user and we don't change it inside the component..

@ethanshar
Copy link
Collaborator Author

Why should we pass the preset to the user? we're getting it from the user and we don't change it inside the component..

It gives the user the ability to have different presets for TextField for example: underline, frame, search, etc..
And we send it back to the users so they can generate different fieldStyle with it..
you can see the private PR the use this feature..

@ethanshar ethanshar requested a review from lidord-wix November 2, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants