Fix Android double press bug after dismissing DateTimePicker dialog #1636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imePicker dialog On Android, dismissing the DateTimePicker dialog by clicking Cancel or by clicking on the background overlay will cause a bug whereby you have to press the DateTimePicker input twice into to launch the DateTimePicker dialog again. This is because the expandable overlay is still in the expanded state after dismissing the dialog. This commit fixes this bug by toggling the expandable overlay when the DateTimePicker dialog is dismissed.
Inbal-Tish
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Android, dismissing the DateTimePicker dialog by clicking Cancel or by clicking on the background overlay will cause a bug whereby you have to press the DateTimePicker input twice into to launch the DateTimePicker dialog again. This is because the expandable overlay is still in the expanded state after dismissing the dialog. This commit fixes this bug by toggling the expandable overlay when the DateTimePicker dialog is dismissed.
Tests
Before
screen-20211103-010940.mp4
After
screen-20211103-011358.mp4
Changelog
Fix Android double press bug after dismissing DateTimePicker dialog