Support passing max item width to grid view #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Nov 16, 2021
| /** | ||
| * @description: A auto-generated grid view that calculate item size according to given props | ||
| * @example: https://github.com/wix/react-native-ui-lib/blob/master/demo/src/screens/componentScreens/GridViewScreen.tsx | ||
| */ | ||
| class GridView extends UIComponent<GridViewProps, State> { |
There was a problem hiding this comment.
Why you're not passing 'State'?
Inbal-Tish
reviewed
Nov 16, 2021
src/components/gridView/index.tsx
Outdated
| /** | ||
| * @description: A auto-generated grid view that calculate item size according to given props | ||
| * @example: https://github.com/wix/react-native-ui-lib/blob/master/demo/src/screens/componentScreens/GridViewScreen.tsx | ||
| */ | ||
| class GridView extends UIComponent<GridViewProps, State> { | ||
| class GridView extends UIComponent<GridViewProps> { | ||
| static displayName = 'GridView'; | ||
|
|
||
| static defaultProps = { | ||
| numColumns: 3, |
There was a problem hiding this comment.
DEFAULT_NUM_COLUMNS instead of "3"
Inbal-Tish
reviewed
Nov 16, 2021
src/components/gridView/index.tsx
Outdated
| /** | ||
| * @description: A auto-generated grid view that calculate item size according to given props | ||
| * @example: https://github.com/wix/react-native-ui-lib/blob/master/demo/src/screens/componentScreens/GridViewScreen.tsx | ||
| */ | ||
| class GridView extends UIComponent<GridViewProps, State> { | ||
| class GridView extends UIComponent<GridViewProps> { | ||
| static displayName = 'GridView'; | ||
|
|
||
| static defaultProps = { | ||
| numColumns: 3, | ||
| itemSpacing: Spacings.s4 |
Inbal-Tish
reviewed
Nov 16, 2021
Inbal-Tish
reviewed
Nov 16, 2021
| import {Colors, Spacings} from 'style'; | ||
| // TODO: we should use asBaseComponent here instead of using UIComponent directly |
There was a problem hiding this comment.
Don't you want to include this in your refactor?
There was a problem hiding this comment.
not at the moment..
Co-authored-by: Inbal Tish <[email protected]>
Inbal-Tish
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
maxItemWidthprop to GridView to support a responsive item width without having to know number of columsWOAUILIB-2207
Changelog
GridView now supports
maxItemWidthprop for a responsive item size (this is instead of passingnumColumnsprop)