Skip to content

Add docs to TabController #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2021
Merged

Add docs to TabController #1646

merged 5 commits into from
Nov 9, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

Add docs to tab controller components

Changelog

Add docs to tab controller components

@Inbal-Tish
Copy link
Collaborator

@ethanshar What about prop's default values? I don't see any...

@ethanshar
Copy link
Collaborator Author

@ethanshar What about prop's default values? I don't see any...

Add some missing default values to props
And for the images key, as I mentioned in one of the comments, Im keeping it so Ill remember to add images to this component.

@ethanshar ethanshar requested a review from Inbal-Tish November 9, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants