Add docs for components p-r #1647
Conversation
| "https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/DialogPicker.gif?raw=true", | ||
| "https://github.com/wix/react-native-ui-lib/blob/master/demo/showcase/Picker/CustomPicker.gif?raw=true" | ||
| ], | ||
| "note": "'useNativePicker' prop requires installing the '@react-native-picker/picker' native library", |
There was a problem hiding this comment.
Is that still relevant?
Aren't we using our own implementation of WheelPicker from Incubator?
There was a problem hiding this comment.
Yes, don't we want to remove the lib/WheelPicker (and this dependency)? Should I add it to V7?
There was a problem hiding this comment.
Better do it officially in v7, yes
There was a problem hiding this comment.
Added a row to V7
| "name": "ProgressiveImage", | ||
| "category": "animationsAndGestures", | ||
| "description": "Image component that loads first a small thumbnail of the images, and fades-in the full-sized image with animation once it's loaded", | ||
| "extends": ["Animated.Image"], |
There was a problem hiding this comment.
What's interesting in extends is to let the user understand what other props are supported. so I think Image is enough in this case. WDYT?
There was a problem hiding this comment.
mmm, I see we're using our AnimatedImage and not actually Animated.Image directly, so there are other props, should I change it to AnimatedImage or Image?
There was a problem hiding this comment.
If AnimatedImage is our component then yes let's change to AnimatedImage, otherwise Image is enough
Co-authored-by: Ethan Sharabi <[email protected]>
Description
Add docs for components p-r
Changelog
Add docs for components p-r