Skip to content

Fix issue with TextField hint is missing when using floatingPlaceholder #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

Fix an issue where TextField hint prop didn't show because it conflicted with the floating placeholder.
Now it should work when the users pass floatingPlaceholder only if they also pass floatOnFocus

These examples can show the different variations

<Incubator.TextField placeholder="Placeholder"/>
<Incubator.TextField useCustomTheme floatingPlaceholder={false} placeholder="Placeholder" hint="Helper"/>
<Incubator.TextField useCustomTheme floatingPlaceholder _floatOnFocus placeholder="Placeholder" hint="Helper"/>
<Incubator.TextField useCustomTheme floatingPlaceholder floatOnFocus placeholder="Placeholder" hint="Helper"/>

Changelog

Fix issue with TextField hint is missing when using floatingPlaceholder (still requires to pass floatOnFocus)

@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Nov 14, 2021
@lidord-wix lidord-wix merged commit 6305921 into master Nov 15, 2021
@ethanshar ethanshar deleted the fix/TextField_missingHint branch April 18, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants