Skip to content

Drawer - fix leftToggle for RTL #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2021
Merged

Drawer - fix leftToggle for RTL #1673

merged 3 commits into from
Nov 24, 2021

Conversation

Inbal-Tish
Copy link
Collaborator

Description

Drawer - fix leftToggle for RTL

Changelog

Drawer - fix leftToggle for RTL

@lidord-wix
Copy link
Contributor

lidord-wix commented Nov 17, 2021 •
edited
Loading

There are still few issues:

  1. In RTL, without left item, the left toggle still responds.
  2. In RTL, without left item, the full swipe doesn't work when using the gesture (not the action button).
  3. in RTL, without right items, the full right swipe is dismissing the drawer instead of toggling the value.

@Inbal-Tish
Copy link
Collaborator Author

@lidord-wix I fixed the first issue but I don't want to waste any more time on this component. We should rewrite it now that we have all the requirements and we know more about how the users use it.

@lidord-wix
Copy link
Contributor

@ethanshar
We all came to the same conclusion, I think we should prioritize rewriting of this component..

@Inbal-Tish
Copy link
Collaborator Author

@ethanshar We all came to the same conclusion, I think we should prioritize rewriting of this component..

I agree but let's merge this to fix crashes

@ethanshar
Copy link
Collaborator

Yes, let's merge this
And Inbal already created a ticket for rewriting this component

@ethanshar ethanshar added the Important for Next Release PR that must be included in the release version label Nov 24, 2021
@lidord-wix lidord-wix merged commit ebe62d3 into master Nov 24, 2021
@Inbal-Tish Inbal-Tish deleted the fix/Drawer_RTL_leftToggle branch November 29, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
Important for Next Release PR that must be included in the release version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Inbal-Tish @lidord-wix @ethanshar