Feat/new chips input #1681
Merged
Feat/new chips input #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w more control with fieldStyle
lidord-wix
reviewed
Nov 25, 2021
Comment on lines
46
to
48
| const styles = StyleSheet.create({ | ||
| container: {} | ||
| }); |
src/incubator/ChipsInput/index.tsx
Outdated
Comment on lines
17
to
19
| chips?: ChipProps[]; | ||
| defaultChipProps?: ChipProps; | ||
| onChange?: (chips: ChipProps[], changeReason: ChipsInputChangeReason, updatedChip: ChipProps) => void; |
There was a problem hiding this comment.
Please add descriptions for these props as well
| key={index} | ||
| customValue={index} | ||
| // resetSpacings | ||
| // paddingH-s2 |
There was a problem hiding this comment.
I kept it for now so I'll have a quick reference in case there is something missing while we're migrating.
I added a TODO
ethanshar
added
the
Important for Next Release
lidord-wix
approved these changes
Nov 28, 2021
Comment on lines
1
to
4
| import _ from 'lodash'; | ||
| import React, {Component} from 'react'; | ||
| import {StyleSheet} from 'react-native'; | ||
| import {View, Text, Card, TextField, Button, Colors, Incubator} from 'react-native-ui-lib'; //eslint-disable-line |
There was a problem hiding this comment.
There're few redundant imports here..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reimplement new ChipsInput based on Incubator.TextField (under Incubator)
Changelog
New ChipsInput component based on our new TextField implementation