Checkbox - render tests #1685
Checkbox - render tests #1685
Conversation
| import {render, fireEvent} from '@testing-library/react-native'; | ||
| import Checkbox from '../index'; | ||
|
|
||
| export const testID = 'checkbox'; |
There was a problem hiding this comment.
Why are you exporting the testID?
There was a problem hiding this comment.
I think I've put the TestCase in a different file and it was copy-pasted, 10x
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('Default value is false', async () => { |
There was a problem hiding this comment.
Why your tests are async?
There was a problem hiding this comment.
I blame copy-pasted again. 10x
| expect(onValueChange).toHaveBeenCalledWith(true); | ||
| }); | ||
|
|
||
| it('Send value (false)', async () => { |
There was a problem hiding this comment.
Why you need this test? You checked the default (false) in the previous test, are you checking react's passed prop mechanism or there's a different behavior when passing false over a default false?
There was a problem hiding this comment.
I think I prefer to test explicitly as well as default behaviour, not sure what the best practice, do you want to ask the team?
There was a problem hiding this comment.
Sure, we can ask them. Anyways Let's leave it in the meantime
|
|
||
| it('Disabled (value = true)', async () => { | ||
| const props = {onValueChange, value: true, disabled: true}; | ||
| const element = <TestCase {...props}/>; |
There was a problem hiding this comment.
You can pass on the 'element' const and extract getByTestId directly (like you did in the other tests)
Description
Checkbox - render tests
Changelog
Checkbox - render tests