WheelPicker - render tests #1688
Conversation
|
@lidord-wix I'm waiting for this PR to add another render test for my bug fix. Can you please make this a priority? |
src/uilib-test-renderer/helper.ts
Outdated
| @@ -12,4 +13,8 @@ const findStyle = <T>(key: string, component: Component): T => { | |||
| return StyleSheet.flatten(component.props.style)[key]; | |||
| }; | |||
|
|
|||
| export {findStyle}; | |||
| const FireOnMomentumScrollEnd = (component: any, {x, y}: {x?: number, y?: number}) => { | |||
There was a problem hiding this comment.
You need to use lower case for functions.
Also, 'helper' is a very general file. I would move this to a scrollView helper file.
The 'nativeEvent' configuration I would move to a separate function, as you might add more helper functions that will need it, like 'onScroll'.
|
|
||
| //TODO: make this test work | ||
| // describe('Item', () => { | ||
| // it('should color selected index with activeColor', () => { |
There was a problem hiding this comment.
This description is not very clear on what you want to test (where is the verb in this sentence?)
| numberOfVisibleRows={NUM_OF_ROWS} | ||
| itemHeight={ITEM_HEIGHT} | ||
| initialIndex={0} | ||
| activeTextColor={'red'} |
There was a problem hiding this comment.
Please use uilib colors (Color.red30, Colors.blue30)
|
|
||
| FireOnMomentumScrollEnd(flatList, {y: 200}); | ||
|
|
||
| expect(onChangeMock).toHaveBeenCalled(); |
There was a problem hiding this comment.
this is a redundant test as the next test coves it already.
Description
Enter description to help the reviewer understand what's the change about...
Changelog
Add a quick message for our users about this change (include Compoennt name, relevant props and general purpose of the PR)