WheelPicker (incubator) - fix updates #1693
Conversation
…when 'initialValue' changes
src/incubator/WheelPicker/index.tsx
Outdated
|
|
||
| if (prevInitialValue.current !== initialValue) { | ||
| // don't invoke 'onChange' if 'initialValue' changed | ||
| prevInitialValue.current = initialValue; |
There was a problem hiding this comment.
I wouldn't set the prevInitialValue value here just because scrollToIndex method is being called in several places.
Instead I'd set in the useEffect that handle the initialValue update (right after triggering the scroll)
There was a problem hiding this comment.
Not sure I understand. In all other cases, it should not pass the condition...
There was a problem hiding this comment.
Yes but technically the responsibility for re-setting the prevInitialValue is in the relevant useEffect and not in the method it calls to.
If someone will change the implementation of scrollToIndex they might break the functionality of prevInitialValue
There was a problem hiding this comment.
I don't see how it works... Let's talk when you're available
ethanshar
added
the
Important for Next Release
Description
WheelPicker (incubator) - allow 'items' change; block 'onChange' call when 'initialValue' change.
Changelog
WheelPicker (incubator) - allow 'items' change; block 'onChange' call when 'initialValue' change.