Skip to content

Feat/date time picker ts #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 10, 2021
Merged

Feat/date time picker ts #1694

merged 9 commits into from
Dec 10, 2021

Conversation

ethanshar
Copy link
Collaborator

Description

This PR is a little big, but there's nothing exciting about it.. this is what I did

  • Covert BaseInput file to TS and set // @ts-nocheck to avoid TS checking
  • Convert (old) TextField file to TS and also set // @ts-nocheck to avoid TS checking
  • Migrated DateTimePicker component to TS
  • Fix minor relevant TS with Dialog's height prop

Changelog

Convert DateTimePicker component to TS

@ethanshar ethanshar requested a review from M-i-k-e-l November 25, 2021 07:45
M-i-k-e-l
M-i-k-e-l reviewed Nov 28, 2021
View reviewed changes
src/components/dateTimePicker/index.tsx
import View from '../view';
import Button from '../button';


const MODES = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be removed.
I've tried renaming the screen to tsx and I think you need to edit the index.d.ts (remove manual typings and link the auto generated types).
I still get errors in the screen, but I did not dig deeper into it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
I moved the example screen to ts
I fixed the export in generatedTypes/index
and fix various errors in the example screen

@ethanshar ethanshar requested a review from M-i-k-e-l December 4, 2021 08:05
M-i-k-e-l
M-i-k-e-l approved these changes Dec 5, 2021
View reviewed changes
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, you can switch MODES to type MODES = 'date' | 'time'; if you like.

@ethanshar ethanshar enabled auto-merge (squash) December 10, 2021 09:04
@ethanshar ethanshar merged commit d499000 into master Dec 10, 2021
@ethanshar ethanshar deleted the feat/DateTimePicker_TS branch June 13, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanshar @M-i-k-e-l