-
Notifications
You must be signed in to change notification settings - Fork 734
Feat/new toast #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new toast #1696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the hooks are making a lot of sense :) I left few specific comments.
The following are more generic:
- It might be a bug in the example screen, but when dismissing the toast by sliding it down or up, you should press the
Toggle toast
button 3 times to present it again (instead of 1). - There's a bug in the attachment feature, you can see it when sliding the toast right/left (happens on private as well).
- I think it is a better API to have a
customContent
prop instead of getting it as children, it'll also be more clear to us in the future. - Consider exporting the toast presets so users will be able to use
Toast.presets.SUCCESS
.
@ethanshar did you fix these issues? |
Not all, I'll go over them again.. thanks |
|
Description
Please Review - Don't Merge!
This contains lots of files, most of them are assets and generated types. It'll be best to review this PR by commits
This is the new implementation of our Toast component (taken from the private lib)
The component's code has been refactored to a functional component
Im using separate helper hooks for different parts of logic of the component.
Few alterations I did
offline
preset for the private usage we have (in private we deepened on theisConnected
prop)Changelog
New Toast component (under Incubator) with better UI and lots of new features