Image - support SVG from uri #1712
Conversation
| @@ -38,6 +40,13 @@ enum SizeType { | |||
| Percentage = '50%' | |||
| } | |||
|
|
|||
| enum SvgType { | |||
There was a problem hiding this comment.
Feels like this enum should be exported from the 'SvgImage' component... You can also use it in the component by first determining the source type and the have a switch case to the return instead of many 'if' statements - will be way cleaner
There was a problem hiding this comment.
I don't think this should be in the SvgImage, the user does not need to be aware of these different types, I'm not sure if it's "wrong" to put the different type here or not, perhaps I should add some tests though.
Regarding the single return, generally I agree with it, but it is a matter of taste, and I feel like it is fine the way it is currently (since the type is not coming from the component).
There was a problem hiding this comment.
For the record, I tried to add some tests, but:
- There is no
onLoad\onErrorprops in the SVG components. - Snapshot tests have issues as well: some random things fail them (not sure how to mock these), might need to mock timers etc.
- Lastly I tried to use the (old method) of snapshot testing using
react-test-renderer, again it did not work for me, since the remote images need to load somehow.
Description
Image - support SVG from uri
Ticket number: 2328
Changelog
Image - support SVG from uri