Infra/ design tokens infra #1752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 4, 2022
src/style/designTokens.ts
Outdated
| import {colorsPalette} from './colorsPalette'; | ||
|
|
||
| export const designTokens = { | ||
| ...colorsPalette, |
There was a problem hiding this comment.
I wouldn't include the system colors palette in the tokens, It might be good for us to have a clear separation between the two objects in the future.
In the Colors class you can load the all together
src/style/colors.ts
Outdated
| @@ -11,7 +12,7 @@ export class Colors { | |||
| [key: string]: any; | |||
|
|
|||
| constructor() { | |||
| const colors = Object.assign(colorsPalette, themeColors); | |||
| const colors = Object.assign(designTokens, themeColors); | |||
There was a problem hiding this comment.
See my previous comment on separating between the tokens and colorsPalette, here you can join them together instead of include the colorsPalette in the tokens
src/style/colors.ts
Outdated
| const colorObject = new TypedColors(); | ||
| colorObject.loadColors(colorsPalette); | ||
| colorObject.loadColors(designTokens); |
ethanshar
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add designTokens infra
Changelog
Add designTokens infra