Support custom item render in GridView #1775
Conversation
ethanshar
changed the title
| children: isLastItem ? this.renderLastItemOverlay() : undefined | ||
| }; | ||
|
|
||
| return renderCustomItem ? renderCustomItem(itemProps) : <GridListItem {...itemProps}/>; |
There was a problem hiding this comment.
We don't usually send (as far as I remember) our configuration to the custom render function, is this a new approach or a special case?
Also, I feel like the name (item in the definition above) should be more along "suggested props" if this is how it's called, not sure how to call it though.
There was a problem hiding this comment.
Not sure I understand the comment.
What you mean by configuration?
What I did is just pass the props I usually pass to GridListItem to the custom render so it can use it.
Technically, we render in private a wrapper of GridListItem (check the private PR)
There was a problem hiding this comment.
I totally missed the email from private (probably archived it, thinking it's the same one).
Description
Support renderCustomItem in GridView
Changelog
Support renderCustomItem prop in GridView