Button tests with test kit #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 18, 2022
| @@ -0,0 +1,142 @@ | |||
| import React, {useState} from 'react'; | |||
There was a problem hiding this comment.
This is the spec that checks the driver? maybe it's better to name the file index.driver.spec.js?
There was a problem hiding this comment.
I don't think it right to say that it checks the driver.
more like, it checks the button using the driver.
I still not sure what is good name for this, so I will change like you say
ethanshar
approved these changes
Jan 18, 2022
|
@Dan-Kovalsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create the first version of test kit for some basic components using react-native/testing-library.
Use it to write tests for the Button component
Changelog
expose testkits for: Text, Image, Button