Skip to content

replace moment for smaller bundler #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ekoeryanto
Copy link

Description

Enter description to help the reviewer understand what's the change about...

Changelog

Add a quick message for our users about this change (include Compoennt name, relevant props and general purpose of the PR)

@M-i-k-e-l
Copy link
Collaborator

@ethanshar we probably cannot merge this as-is, but perhaps we can create an optional-dependency for this?

@ethanshar
Copy link
Collaborator

ethanshar commented Apr 3, 2022

@M-i-k-e-l
Why not use this light package instead?
Does it work the same as moment in this case?

@M-i-k-e-l
Copy link
Collaborator

TBH I did not test it because I assumed we still need moment in private anyway, so it'll just add another dependency and not really help us.
Another thing to consider is users will need to migrate and this should be done in a major version.

@stale
Copy link

stale bot commented Jun 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 4, 2022
@ethanshar
Copy link
Collaborator

TBH I did not test it because I assumed we still need moment in private anyway, so it'll just add another dependency and not really help us.
Another thing to consider is users will need to migrate and this should be done in a major version.

I think we should consider using the light-date package. For our public users it makes sense not to have them install moment
And for our internal case it's redundant since it's a light package anyway

@stale stale bot removed the wontfix label Jun 6, 2022
@stale
Copy link

stale bot commented Aug 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 10, 2022
@stale stale bot closed this Sep 4, 2022
@M-i-k-e-l M-i-k-e-l reopened this Sep 5, 2022
@stale stale bot removed the wontfix label Sep 5, 2022
@M-i-k-e-l M-i-k-e-l added the V7 label Sep 7, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 9, 2022
@M-i-k-e-l M-i-k-e-l removed the wontfix label Nov 9, 2022
@stale
Copy link

stale bot commented Jan 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 15, 2023
@M-i-k-e-l M-i-k-e-l removed the wontfix label Jan 22, 2023
@stale
Copy link

stale bot commented Mar 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 24, 2023
@M-i-k-e-l
Copy link
Collaborator

Hi @ekoeryanto,

I've opened a PR that takes into account our optional dependencies (#2544), thank you very much for this contribution, apologies for not merging as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants