-
Notifications
You must be signed in to change notification settings - Fork 734
replace moment for smaller bundler #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ethanshar we probably cannot merge this as-is, but perhaps we can create an optional-dependency for this? |
@M-i-k-e-l |
TBH I did not test it because I assumed we still need |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think we should consider using the light-date package. For our public users it makes sense not to have them install moment |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @ekoeryanto, I've opened a PR that takes into account our optional dependencies (#2544), thank you very much for this contribution, apologies for not merging as is. |
Description
Enter description to help the reviewer understand what's the change about...
Changelog
Add a quick message for our users about this change (include Compoennt name, relevant props and general purpose of the PR)