support margin modifiers in SkeletonView #1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 30, 2022
| const key = timesKey ? `${timesKey}-${index}` : `${index}`; | ||
| return ( | ||
| <SkeletonView | ||
| modifiers={{}} |
There was a problem hiding this comment.
Can we pass null here instead?
There was a problem hiding this comment.
It throws a TS error:
Type 'null' is not assignable to type 'ExtractedStyle'.ts(2322)
I can set it to null and add a @ts-expect-error, wdyt?
There was a problem hiding this comment.
Where the modifiers prop typing comes from?
What about passing undefined or is that ignored?
There was a problem hiding this comment.
Same error for undefined as well.
The type comes from asBaseComponent:
modifiers: ReturnType<typeof Modifiers.generateModifiersStyle>;
ethanshar
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support margin modifiers in SkeletonView
WOAUILIB-2175
Changelog
Support margin modifiers in SkeletonView Component