Update version of react-native-reanimated to 2.4.0 #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swipe the carousel, label does not change color.
|
For future reference a few workarounds were aded:
|
lidord-wix
reviewed
Feb 6, 2022
| @@ -103,6 +101,7 @@ function PageCarousel({...props}) { | |||
| scrollEventThrottle={16} | |||
| contentOffset={initialOffset} // iOS only | |||
| onLayout={scrollToInitial} // Android only | |||
| onMomentumScrollEnd={() => {}} // workaround for useAnimatedScrollHandler.onMomentumEnd not being called (https://github.com/software-mansion/react-native-reanimated/issues/2735) | |||
There was a problem hiding this comment.
It'll override the onMomentumScrollEnd prop that the user might send, no?
There was a problem hiding this comment.
This is VERY strange, if the user sends onMomentumScrollEnd the workaround stops working (even though this is overriding it).
There was a problem hiding this comment.
Fixed by adding useCallback
lidord-wix
approved these changes
Feb 6, 2022
M-i-k-e-l
added a commit
that referenced
this pull request
Feb 6, 2022
* Update versions of react-native-reanimated and react-native-gesture-handler * Update reanimated to 2.3.1 * Fix exposed issue with interpolateColors can't handle undefined values * Bumped reanimated to 2.4.0 * Fix TabController on Android Swipe the carousel, label does not change color. * Fix tests (workarounds) * Remove expect errors * Change function name See https://github.com/software-mansion/react-native-reanimated/pull/2792/files * Remove setup which seems to be no longer needed * Revert to old function (for users who use older versions of reanimated) * Change to noop * Allow overriding onMomentumScrollEnd * Fix types Co-authored-by: Ethan Sharabi <[email protected]> Co-authored-by: Miki Leib <[email protected]> (cherry picked from commit 1a8a07a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update version of react-native-reanimated (2.4.0)
Changelog
Update internally versions of react-native-reanimated and react-native-gesture-handler