Skip to content

Revert "Infra/lodash babel plugin (#1815)" #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2022
Merged

Revert "Infra/lodash babel plugin (#1815)" #1825

merged 1 commit into from
Feb 7, 2022

Conversation

M-i-k-e-l
Copy link
Collaborator

This reverts commit 94913a3.

Description

Revert lodash babel plugin
This change is breaking private's tests, we need to make sure private is not broken before re-committing this.

Changelog

Revert lodash babel plugin

@M-i-k-e-l M-i-k-e-l requested a review from lidord-wix February 7, 2022 13:06
@lidord-wix lidord-wix merged commit b7464cb into master Feb 7, 2022
@M-i-k-e-l M-i-k-e-l deleted the infra/revert-lodash-babel-plugin branch February 7, 2022 14:49
@ethanshar
Copy link
Collaborator

You didn't have to revert the whole thing (:
You could just remove the lodash plugin from the babel configuration 😬

lidord-wix added a commit that referenced this pull request Feb 13, 2022
@lidord-wix
Revert "Revert "Infra/lodash babel plugin (#1815)" (#1825)"
0059977 
This reverts commit b7464cb.
@lidord-wix lidord-wix mentioned this pull request Feb 13, 2022
Merged
M-i-k-e-l pushed a commit that referenced this pull request Feb 13, 2022
@lidord-wix
Revert "Revert "Infra/lodash babel plugin (#1815)"" (#1841)
004b9bd 
* Revert "Revert "Infra/lodash babel plugin (#1815)" (#1825)"

This reverts commit b7464cb.

* comment out lodash plugin

* remove commented code
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidord-wix lidord-wix lidord-wix approved these changes

Assignees

@lidord-wix lidord-wix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M-i-k-e-l @ethanshar @lidord-wix