Skip to content

TextField: "isFocused" method added #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2022
Merged

Conversation

avishain
Copy link
Contributor

@avishain avishain commented Feb 10, 2022

Description

Add the ability to check if the TextField (TextInput) is currently focused.

Changelog

Add missing isFocused method on Incubator.TextField ref

Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@D10S60948
I see that the PR build checks fail
Can you please run npm run prepush and see what fails?

@avishain
Copy link
Contributor Author

I don't think that the build's fail is related to the change I made.
It seems related to a tsc comment on AvatarHelper.
Screen Shot 2022-02-10 at 17 53 57

@ethanshar
Copy link
Collaborator

I don't think that the build's fail is related to the change I made.
It seems related to a tsc comment on AvatarHelper.
Screen Shot 2022-02-10 at 17 53 57

Your PR branch was a little old, I sync it with master. should be ok now

@ethanshar ethanshar merged commit 974d786 into master Feb 12, 2022
@ethanshar ethanshar deleted the text-field-input-ref-fix branch April 18, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants