Feat/incubator dialog small changes #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Feb 14, 2022
There was a problem hiding this comment.
@M-i-k-e-l
Some general comments on the Dialog code (not just this PR changes) - mainly structure and naming..
- I see all sub components of the Dialog are prefixed with
Dialog..(DialogDivider, DialogKnob, DialogText...) not sure all of the sub components need this prefix, it feels a bit much - The separation to small components in some cases is an overkill (DialogKnob and DialogDivider are one liners)
- DialogText is relevant only to the Header, so maybe we can name it
HeaderContentinstead?
Inbal-Tish
approved these changes
Feb 14, 2022
|
@M-i-k-e-l Approved, merge at will. If you are making the changes Ethan suggested in this PR, you can ping me to review again, I suggest you'll do it in a separate one after you merge these changes. |
|
I'll create another PR, 10x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incubator.Dialog - a few small changes
Look at each commit separately for convenience.
Changelog
Incubator.Dialog - remove extra components + support configuration