Feat/incubator dialog support size and custom header #1846
Conversation
| const renderContent = () => { | ||
| if (enable) { | ||
| return ( | ||
| <FadedScrollView {...otherScrollableProps} useGesture showEndFader endFaderProps={FADER_PROPS}> |
There was a problem hiding this comment.
Why the dialog need to contain a scrollview and the fader logic?
The Dialog should be a simple container that can render anything..
There was a problem hiding this comment.
I think we had this request at some point, and we have this functionality in private's ActionSheet, I thought it'll be better to implement here for all Dialogs. What's the drawback?
| @@ -0,0 +1,65 @@ | |||
| import {isUndefined} from 'lodash'; | |||
There was a problem hiding this comment.
Is this hook meant to convert string percentages to numbers?
Cause react-native already supports string percentages
There was a problem hiding this comment.
This is what I've talked with you about; RN does have this functionality, but it does not work because of the different views in the Dialog, I did not find a way to not break other things and have this work 😞
There was a problem hiding this comment.
Let's go over it together maybe we can find a solution
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
M-i-k-e-l
deleted the
feat/incubator-dialog-support-size-and-custom-header
branch
Description
Incubator.Dialog - support
width,height(including percentage) andcustomHeader.Add
FadedScrollView- auto scroll according to content + fader.I've added
height={'40%'}to the screen, you can change to a number \ towidthetc.As we've discussed, I am not very fond of the
useSizeStylesolution, but did not find a better solution for the percentage part.Changelog
Incubator.Dialog - support
width,height(including percentage),customHeaderandFadedScrollView(auto scroll according to content + fader).