Skip to content

Infra/ Move all colors and DesignTokens to public #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2022
Merged

Infra/ Move all colors and DesignTokens to public #1848

merged 3 commits into from
Feb 15, 2022

Conversation

lidord-wix
Copy link
Contributor

@lidord-wix lidord-wix commented Feb 14, 2022 •
edited
Loading

Description

Move all colors and DesignTokens to public
Add supportDarkMode method to Colors class to allow enabling the dark mode tokens from private when the appearance changes
WOAUILIB-2534

Changelog

Move all colors and DesignTokens to public

@lidord-wix lidord-wix requested a review from M-i-k-e-l February 14, 2022 14:02
M-i-k-e-l
M-i-k-e-l reviewed Feb 14, 2022
View reviewed changes
src/style/colorsPalette.ts
Comment on lines +89 to +90
violet1: '#170E5C',
violet5: '#231690',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are these from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alexey generated them :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see them in the docs 🤷‍♂️

@lidord-wix lidord-wix requested a review from M-i-k-e-l February 15, 2022 08:50
@M-i-k-e-l M-i-k-e-l enabled auto-merge (squash) February 15, 2022 09:11
@M-i-k-e-l M-i-k-e-l merged commit 3143056 into master Feb 15, 2022
@lidord-wix lidord-wix deleted the infra/move_colors_and_tokens_to_public branch February 22, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l M-i-k-e-l approved these changes

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidord-wix @M-i-k-e-l